Key Information

Register
Submit
The challenge is finished.

Challenge Overview

We have been trying to get stricter on our code style standards, and now the challenge-details app is horribly out of style (so to speak). In this challenge, we need you to refactor and tweak the code so that it adheres to our new style guide (https://gitlab.com/topcoderinc/angularjs-styleguide).

Requirements:

  • Adhere to the style guide as closely as possible. It will be used in the review process
  • Address all TODOs on in the challenge-details app on the branch (https://gitlab.com/topcoderinc/tc-site/commits/tom-S-250091-add-todos, TODO comments are all done under this https://gitlab.com/topcoderinc/tc-site/tree/tom-S-250091-add-todos/wp-content/themes/tcs-responsive/js/app/challenge-details)
    • Please note that the tasks "Get rid jQuery! Move DOM Logic into directives, etc." in ng-challenge-detail-software.js and ng-challenge-result.js is NOT in the scope of this challenge
  • Please put a big emphasis on refactoring to match the style guide in this challenge��� – read the style guide carefully and note the specific sections on controllers, directives, services, etc.���
    • get things out of the global namespace
      • ���wrap things in anonymous functions
    • move logic out of controllers and into services and factoriesrename files so that they have useful names
    • use comments to make code more readable (don't have to go through all code add comments – just do it at the tops of files and at key points)
    • use controllerAs syntax in template files
    • use $inject to inject dependencies
    • and in general, just rewrite things so the match what the guide advises and clean up messiness in existing Angular code
      • ���we're not addressing the jQuery we're using in ng-challenge-detail-software.js – a different challenge will address this
      • there's some general hackiness going on, so in addition to following the styleguide, try to move things toward 'the Angular way' as much as possible
    • ���also in general, keep in mind that we want the guide to be our new standard that we bind ourselves to – try to make the code easy to read and suitable for use as an example
    • please ask questions in the forums – I know we're asking for big, general things, and we'll be happy to clarify on specifics wherever discretion seems necessary

Resources and Guidelines



Final Submission Guidelines

We shouldn't need to introduce any new libraries. This should just be a refactor of what's already there.

- Please submit updated files and Patch file of changes only
- Deployment documentation
- Any new js or css file must be included in the registry. Learn about this on 
script and style registry section
- We will have winner to submit pull request once winner declared 

REVIEW STYLE:

Final Review:

Community Review Board

Approval:

User Sign-Off

SHARE:

ID: 30045044